java-naming-readability

Trigger: Java naming, readability, test names. Evaluate Java naming and readability with domain language.

SKILL.md

GitHub

Activation Contract

Load this skill when reviewing Java refactor plans for: Java naming, readability, test names.

Hard Rules

  • Class names: UpperCamelCase nouns; interfaces: UpperCamelCase; methods: lowerCamelCase verbs or verb phrases; variables: lowerCamelCase; constants: UPPER_SNAKE_CASE.
  • Prefer semantic test names such as shouldExpectedBehaviorWhenCondition; accept should_expected_behavior_when_condition when the repo consistently uses underscores.
  • Respect consistent existing repo style, especially test naming.
  • Prefer domain terms over generic technical names.
  • Avoid abbreviations unless widely understood.
  • Do not propose mass renames without clear maintainability benefit.
  • Preserve observable behavior; label functional changes as follow-up.
  • Require evidence for every recommendation, or mark it as a hypothesis.

Decision Gates

Signal Action
Concrete evidence exists Create a finding with file:line evidence and the smallest safe refactor.
Evidence is incomplete Mark as hypothesis and lower confidence.
Recommendation is cosmetic or speculative Omit it unless maintainability benefit is clear.

Execution Steps

  1. Inspect the target and nearby tests only as needed for this lens.
  2. Identify findings that match this skill's responsibility.
  3. Recommend the smallest safe behavior-preserving refactor.
  4. Note validation and rollback implications where material; the calling agent decides where they land.

Output Contract

Return findings in the calling agent's output contract — that contract wins over any field list here. Every finding carries file:line evidence or is marked hypothesis. Return no_findings when this lens has no material issue.

References

None.